Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mislabeled Die Image Filenames #288

Open
davidagnome opened this issue Apr 1, 2021 · 5 comments
Open

Mislabeled Die Image Filenames #288

davidagnome opened this issue Apr 1, 2021 · 5 comments
Labels

Comments

@davidagnome
Copy link
Contributor

I noticed that Ability Dice (Green) and Proficiency Dice (Yellow) use incorrect filenames.

The green 8-sided die is mislabelled Proficiency and the yellow ,12-sided die is mislabeled Ability:
https://github.com/swsheets/swsheets/tree/staging/assets/static/images
https://github.com/swsheets/swsheets/tree/staging/design

For reference:
https://www.fantasyflightgames.com/en/news/2012/11/19/at-the-core/

@duffn duffn added the bug label Apr 1, 2021
@duffn
Copy link
Member

duffn commented Apr 1, 2021

Thanks for the report!

@davidagnome
Copy link
Contributor Author

No problem. Is the logic accurate that references these files in?
_form_skills.html.eex
_show_skills.html.eex

@duffn
Copy link
Member

duffn commented Apr 1, 2021

It should be accurate, yes.

@davidagnome
Copy link
Contributor Author

I've also create higher quality dice for assets/static/images in both PNG and SVG (the latter would mean print-perfect scaling) -- along with the original designs in Affinity Designer format for the designs folder.
Imgur Gallery

Happy to upload. The fixed height/width CSS changes from #287 mean we can use either safely for higher quality, aspect-ratio correct sizing.

@duffn
Copy link
Member

duffn commented Jul 10, 2021

If you want to update to better assets, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants