Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Engaged to Close on vehicle range #219

Open
duffn opened this issue Feb 5, 2020 · 2 comments
Open

Change Engaged to Close on vehicle range #219

duffn opened this issue Feb 5, 2020 · 2 comments
Assignees
Labels

Comments

@duffn
Copy link
Member

duffn commented Feb 5, 2020

https://community.fantasyflightgames.com/topic/304147-swsheets-under-new-stewardship/page/2/?tab=comments#comment-3887259

@duffn duffn added the bug label Feb 5, 2020
basseyjake added a commit to basseyjake/swsheets that referenced this issue Feb 6, 2020
basseyjake added a commit to basseyjake/swsheets that referenced this issue Feb 6, 2020
@basseyjake
Copy link

web/templates/vehicle/_form.html.eex line: 234
<%= options(get_field(@vehicle, :sensor_range), ["", "Engaged", "Short", "Medium", "Long", "Extreme", "n/a"]) %>

web/templates/vehicle/_form_attacks.html.eex line: 26
<%= options(get_field(attack, :range), ["", "Engaged", "Short", "Medium", "Long", "Extreme", "n/a"]) %>

@duffn
Copy link
Member Author

duffn commented Feb 6, 2020

Thanks. Yes, that would do it. We'll need to consider how to handle those that already have selected Engaged. I suppose just migrate them to Close when merging the PR.

As per our Discord discussion, let me know if you have any trouble getting the app up and running locally or have any questions. Thanks for your interest in contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants