Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor validations errors to include all children Changesets #212

Open
duffn opened this issue Jan 28, 2020 · 0 comments
Open

Refactor validations errors to include all children Changesets #212

duffn opened this issue Jan 28, 2020 · 0 comments
Labels
bug

Comments

@duffn
Copy link
Member

duffn commented Jan 28, 2020 •
edited

We should refactor errors to report all errors in a Changeset with relationships. Right now, they would only report in the "root" Changeset in the Changemap in the current setup.

swsheets/web/controllers/vehicle_controller.ex

Line 37 in f9a8223

errors: changemap.root.errors

We need to show validation errors for all child Changesets as well as the character.
@duffn duffn added the bug label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@duffn