Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional struct Equals test cases #282

Open
suyashkumar opened this issue Aug 26, 2023 · 0 comments
Open

Add additional struct Equals test cases #282

suyashkumar opened this issue Aug 26, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@suyashkumar
Copy link
Owner

Not a high priority, but in #280 we introduced some Equals methods for Dataset and children structs that do not rely on reflection (which leads to huge speed improvements). Several sanity check cases were added, but this issue invites folks to add additional test cases or test case generators that exercise more of the Equals functionality across the structs.
@suyashkumar suyashkumar added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 26, 2023
@suyashkumar suyashkumar changed the title Add additional struct equality test cases for coverage Add additional struct Equals test cases Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suyashkumar