Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Delr is displayed in trace logs of releases #4029

Closed
2 tasks done
phughk opened this issue May 13, 2024 · 1 comment · Fixed by #4068
Closed
2 tasks done

Bug: Delr is displayed in trace logs of releases #4029

phughk opened this issue May 13, 2024 · 1 comment · Fixed by #4068
Labels
bug Something isn't working topic:datastore This involves the Datastore engine and transaction code

Comments

@phughk
Copy link
Contributor

phughk commented May 13, 2024

Describe the bug

In #3906 we saw that Delr is being displayed when results are empty. This is useful during development, but we don't want that for release builds.

Steps to reproduce

Start the database with trace logs and look at the terminal output.

Expected behaviour

We shouldn't have messages that Delr is empty

SurrealDB version

1.5.0-beta1

Contact Details

hugh@surrealdb.com

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct
@phughk phughk added bug Something isn't working topic:datastore This involves the Datastore engine and transaction code labels May 13, 2024
@phughk
Copy link
Contributor Author

phughk commented May 13, 2024

This is assigned to community member @LivingLimes

@LivingLimes LivingLimes mentioned this issue May 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working topic:datastore This involves the Datastore engine and transaction code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4029: Add debug flag for delr page empty trace LivingLimes/surrealdb
1 participant
@phughk