Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving sunpy custom CTYPE mapping from astropy source and update mapping from sunpy #7602

Open
samaloney opened this issue Apr 25, 2024 · 0 comments
Labels
Discussion An issue opened for, or undergoing discussion.

Comments

@samaloney
Copy link
Contributor

Provide a general description of the issue or problem.

Essentially move these plus the two at the end to a new dictionary in sunpy SUNPY_CTYPE_TO_UCD1

https://github.com/astropy/astropy/blob/cf99b9e7761c45c15ddc060a76b563574f525df9/astropy/wcs/wcsapi/fitswcs.py#L117-L126

and then somewhere in sunpy

astropy.wcs.wcsapi.fitswcs.CTYPE_TO_UCD1.update(SUNPY_CTYPE_TO_UCD1)

At the moment it hard to know about these as they aren't in the sunpy source code and need to reply on astropy if ever had to change or add new ones. Also if astropy/astropy/issues/16339 is solved would have control over both side in the sunpy source.

@nabobalis nabobalis added the Discussion An issue opened for, or undergoing discussion. label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion An issue opened for, or undergoing discussion.
Projects
None yet
Development

No branches or pull requests

2 participants