Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area-based contours #7420

Open
settwi opened this issue Jan 29, 2024 · 8 comments
Open

Area-based contours #7420

settwi opened this issue Jan 29, 2024 · 8 comments
Labels
Effort Medium Requires a moderate time investment Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required

Comments

@settwi
Copy link

settwi commented Jan 29, 2024

Describe the feature

For X-rays (and radio I think?) we like to put contours on images based on the "area contained." The current GenericMap.contour method, when given percentiles, puts those contours relative to the max value in the map.

If we want to do it by area we have to do a little bit of shenanigans with sorted arrays, like in this gist. We could extend the example to N-dimensions, too.

This would be a pretty small addition to the contour code but probably make people happy!

Proposed solution

See the request! There is an example. Up for debate if we want N-dimension compatibility and how to add units in logically.

@nabobalis nabobalis added Feature Request New feature wanted! Package Novice Requires little knowledge of the internal structure of SunPy map Affects the map submodule Priority Low Slow action required Effort Medium Requires a moderate time investment labels Jan 29, 2024
@eKeiran

This comment was marked as outdated.

@nabobalis

This comment was marked as outdated.

@nabobalis nabobalis added the Good First Issue The best issues for new people to tackle! label Feb 22, 2024
@ryuusama09

This comment was marked as outdated.

@nabobalis

This comment was marked as off-topic.

@AquarlisPrime

This comment was marked as outdated.

@nabobalis

This comment was marked as outdated.

@AquarlisPrime

This comment was marked as outdated.

@AquarlisPrime

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort Medium Requires a moderate time investment Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required
Projects
None yet
Development

No branches or pull requests

5 participants