Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clip_interval and vmin/vmax be passed to MapSequence plotting #7252

Closed
hayesla opened this issue Oct 23, 2023 · 4 comments
Closed

Allow clip_interval and vmin/vmax be passed to MapSequence plotting #7252

hayesla opened this issue Oct 23, 2023 · 4 comments
Labels
Effort Low Requires a small time investment Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required

Comments

@hayesla
Copy link
Member

hayesla commented Oct 23, 2023

Describe the feature

Currently for MapSequence.plot(), you can pass cmap and norm for plotting a sequence following #5889 .

However, it may be nice to also be able to pass clip_interval and vmin/vmax explicitly, such that it follows the same from Map.plot()

For example, currently if you do:

import sunpy.map
import sunpy.data.sample
from astropy.visualization import ImageNormalize

m_seq = sunpy.map.Map([
    sunpy.data.sample.AIA_193_CUTOUT01_IMAGE,
    sunpy.data.sample.AIA_193_CUTOUT02_IMAGE,
], sequence=True)

m_seq.plot(clip_interval=[5, 99.9]*u.percent)

the clipping is only applied to the first image of the sequence. This is the same for passingvmin/vmax,

Proposed solution

Implement it in MapSequence.plot()

@ryuusama09

This comment was marked as outdated.

@nabobalis nabobalis added Package Novice Requires little knowledge of the internal structure of SunPy map Affects the map submodule Priority Low Slow action required Effort Low Requires a small time investment Good First Issue The best issues for new people to tackle! labels Feb 26, 2024
@nabobalis

This comment was marked as outdated.

@dpshelio
Copy link
Member

Did #7253 solve this issue?

@nabobalis
Copy link
Contributor

Probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort Low Requires a small time investment Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required
Projects
None yet
Development

No branches or pull requests

4 participants