-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguishing zero results because of no results, or because of server error #5661
Comments
We could do better, but what some clients do is to raise warnings and then return 0 results. |
I am 👍 to resolving this by recommending people writing clients raise a warning if the server they are querying is down, and by putting such warnings in the sunpy core clients. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
So after doing a bit of testing , I found that |
This weekend the solar orbiter archive was down, which prompted this bug report for a not very nice error being raised by
sunpy-soar
: https://github.com/dstansby/sunpy-soar/issues/11. I think the solution to that issue is to return zero results from the client, so other clients have a chance to return results (e.g. for a time only search). It would be helpful to have a way of informing the user of the difference between:The text was updated successfully, but these errors were encountered: