-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABlog support for furo theme #108
Comments
Ah I see its from the URL. I missed that. Honestly, I have no real idea where to start with that error. |
commented on the furo issue, but it looks like that theme doesn't allow using layout.html. luckily, only two places it's referenced in ablog: https://github.com/sunpy/ablog/search?q=layout.html |
I don't know much about the Sphinx template system (I just started tried to setup a blog with furo theme). Tried to extend Tried that with this patch and @damian-krawczyk 's PoC https://github.com/damian-krawczyk/sphinx-ablog-furo I don't know if this will break other themes or end users installations. I don't propose a PR directly because I don't understand either why Sphinx Doc proposed different And I have no idea either of which option is the best for this issue:
|
The previous patch was wrong... Didn't work when I tried to use it in a more complex example. This seems to be better: |
At furo's end Issue moved from Issues to Discussions by @pradyunsg pradyunsg/furo#262 |
@nabobalis Can you check furo's comment? |
I see, if someone wants to fix this assumptions, I am happy to accept the patch. |
Is anyone working on this? @nabobalis I can try to contribute. |
I am not aware that anyone is working on it. If you want to try to help, please go ahead. |
I've proposed an approach for solving this problem, at scale, in #125 that I think will be more sustainable for all the maintainers involved. |
Doesn't this issue seem to be fixed? I can reproduce it on sphinx 6.2.1 + ablog 0.11.6 + furo 2024. |
I found that there are still
|
I should add a test build to check compatibility with furo. |
@nabobalis Any plan to fix it? I have no idea how to do that :'( |
I will try but I won't promise an ETA. |
I still see the “layout.html” problem as well.
This is with Ablog 0.11.6. The moment I set the template to Furo when Ablog is enabled, I get this problem. If I change either the theme or disable the Ablog extension, the problem goes away. |
Description
Hi,
I would like to use
ABlog
with furo theme, but I'm encountering an error:Here simple example with
alabaster
theme (works with ablog):https://sphinx-ablog-alabaster.readthedocs.io/en/latest/
https://github.com/damian-krawczyk/sphinx-ablog-alabaster
conf.py
:html_theme = 'alabaster'
Here simple example with
pydata_sphinx_theme
(works with ablog)https://sphinx-ablog-pydata-sphinx-theme.readthedocs.io/en/latest/
https://github.com/damian-krawczyk/sphinx-ablog-pydata_sphinx_theme
conf.py
:html_theme = 'pydata_sphinx_theme'
Here simple example with
furo
(doesn't work with ablog, see error)https://sphinx-ablog-furo.readthedocs.io/en/latest/
https://github.com/damian-krawczyk/sphinx-ablog-furo
conf.py
:html_theme = 'furo'
The only difference in listed repositories is mentioned config.
I've already raised issue for furo but before I get back to them I would like to get feedback from you to make sure that this is not something to be fixed on your side?
The text was updated successfully, but these errors were encountered: