Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] : The Contents In the Navbar does not have equal padding. #389

Open
CodeWizarz opened this issue Jan 26, 2023 · 17 comments
Open

Comments

@CodeWizarz
Copy link

Screenshot from 2023-01-26 13-24-59

The contents in a navbar or header may be designed with a specific hierarchy in mind, with certain elements intended to stand out more than others. In order to achieve this, the padding and spacing between elements may be irregular. This allows for a more dynamic and visually interesting layout, as well as making it easier for users to quickly identify important elements within the navigation. Additionally, sometimes irregular padding and spacing is used to indicate different sections or types of content. Ultimately, the goal is to create an intuitive and visually appealing navigation experience for the user.
@quozl Can you please look into this, thanks in advance.

@quozl
Copy link
Contributor

quozl commented Jan 26, 2023

Thanks, but I disagree. Our critical issue with the web site is the out of date content, and that activity by Sugar Labs developers is not being captured as new content. Given the critical issue, the web site style and layout really don't matter. We should be using a theme that is used by other web sites, in order to maximise uptake of our content, minimise effort to maintain, and properly direct volunteers to our core products. Our web site is not our core product. We should not be modifying the theme, style, or layout.

@CodeWizarz
Copy link
Author

@quozl I understand your concerns about the outdated content and the lack of engagement from Sugar Labs developers. However, I believe that a visually appealing and user-friendly website will also play a crucial role in attracting and retaining visitors, as well as promoting our core products effectively. Perhaps we can consider a balance between addressing the content issue and updating the theme to align with industry standards.

@The-Priya-Saw
Copy link

can I work on this issue?

@quozl
Copy link
Contributor

quozl commented Jan 26, 2023

No, content has priority. Why work on an outdated web site? I've just had a look at nav.html and most of the links are out of date. The content must be fixed first. If you're looking for something to do, #387 needs review.

@CodeWizarz
Copy link
Author

@quozl I don't intend to do this but how about we use docsaurus to create a new site other than using those bootstrap and html5. I can make a dummy webpage with the contents of sugarlabs using docsaurus I'm good with js. If it looks promising we can use the webpage we(don't mind including members) created and migrate to the new one. If it's ok with you.

@quozl
Copy link
Contributor

quozl commented Jan 27, 2023

Thanks, but I don't see how that would help. Have you reviewed #387?

@CodeWizarz
Copy link
Author

So you would like to remove sidebar social media icons..? and make some changes to the footer social icons and the one i suggested that the navbar to have equal padding right. Well i can do that

@quozl
Copy link
Contributor

quozl commented Jan 27, 2023

I've made a pull request for removing the social media icons, but I'm waiting for review.

@chimosky
Copy link
Member

chimosky commented Jan 27, 2023

@quozl I don't intend to do this but how about we use docsaurus to create a new site other than using those bootstrap and html5. I can make a dummy webpage with the contents of sugarlabs using docsaurus I'm good with js. If it looks promising we can use the webpage we(don't mind including members) created and migrate to the new one. If it's ok with you.

I agree with quozl, I don't see how this would solve the problem however I do agree with this issue you've opened as it's visually disorienting once you notice the navbar is the way it is.

@quozl
Copy link
Contributor

quozl commented Jan 27, 2023

From what I've seen so far in nav.html we just need a tiny change to the list item class attribute to use some other Bootstrap class. It's the sort of thing we need a pull request for rather than an issue.

@chimosky
Copy link
Member

chimosky commented Jan 30, 2023

From what I've seen so far in nav.html we just need a tiny change to the list item class attribute to use some other Bootstrap class. It's the sort of thing we need a pull request for rather than an issue.

Agreed, @devbobby feel free to open a PR to continue the discussion.

@SrijanVerma04
Copy link

Can I contribute to this issue?? please assign me this issue?
Actually I am new to open source so bit confused but i think i can fix this issue!!

@quozl
Copy link
Contributor

quozl commented Feb 5, 2023

@SrijanVerma04 please explain why you think anyone needs to be assigned? We expect pull requests as next step.

@SrijanVerma04
Copy link

SrijanVerma04 commented Feb 5, 2023

@quozl sorry my bad ...i will directly create a pull request!

@quozl
Copy link
Contributor

quozl commented Feb 5, 2023

Thanks!

@rishivyas24
Copy link

is anyone working on this issue?

@quozl
Copy link
Contributor

quozl commented Feb 10, 2023

There is no way to tell. We do not allocate issues.

classr-22 added a commit to classr-22/www that referenced this issue Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants