Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select all button in Journal has no effect. #945

Open
chimosky opened this issue Apr 30, 2021 · 11 comments
Open

Select all button in Journal has no effect. #945

chimosky opened this issue Apr 30, 2021 · 11 comments

Comments

@chimosky
Copy link
Member

chimosky commented Apr 30, 2021

Steps to reproduce

  • Search for existing files.
  • Select one then use the Select all button above items.
  • Selections are deselected instead of being selected.

Nothing helpful shown in logs.

@sourabhaa
Copy link

One more observation, this happens only if the name of the file(as mentioned inside activity.info) is not entered completely in the search-box.
Example : To select terminal activity, typing at least 'terminal' will give expected results. Anything less than that like 'ter' will result in this error.
Also, I noticed if complete name of an activity is searched, the auto search result will include all other activities.

@chimosky
Copy link
Member Author

chimosky commented May 4, 2021

One more observation, this happens only if the name of the file(as mentioned inside activity.info) is not entered completely in the search-box.

Thanks for that, just noticed this too and it shouldn't have to be the case. @quozl was there any particular reason for this?

Also, I noticed if complete name of an activity is searched, the auto search result will include all other activities.

That's expected given what you mentioned above.

Hope you're doing okay @sourabhaa, been hearing about what's been happening in India.

@quozl
Copy link
Contributor

quozl commented May 4, 2021

I tried but can't reproduce. Can you explain further what happens and what you expected?

@chimosky
Copy link
Member Author

chimosky commented May 4, 2021

I tried but can't reproduce. Can you explain further what happens and what you expected?

When I search for TamTam all the TamTam instances show in the search results and after selecting one, I use the select all button and I expect that everything that came up after the search be selected but what happens is, the selected activity is deselected and the search is automatically cleared.

@sourabhaa
Copy link

For more clarity,

  1. Search terminal , all search history of terminal activity is listed, Select all feature works fine (because inside activity.info, name = Terminal).
  2. Search term, all search history of terminal activity is listed, Select all button deselects.
  3. Search terminal activity, all search history of all the activities(which has 'activity' in its name as shown in the search list (not in activity.info)) is listed, Select all button works fine(selects all the activities listed).

That's expected given what you mentioned above.

The third case is what I meant. You mean both 2nd and 3rd case have same cause?

Hope you're doing okay @sourabhaa, been hearing about what's been happening in India.

Thanks for asking @chimosky , I'm in perfect health (but the situation is worsening...)

@chimosky
Copy link
Member Author

chimosky commented May 5, 2021

The third case is what I meant. You mean both 2nd and 3rd case have same cause?

No, I mean when you search for an activity and include the words "Activity" all activities are bound to show up in the result as they have that in their name when saved as journal objects.

I'm in perfect health (but the situation is worsening...)

Glad you're okay, I hope things change.

@quozl
Copy link
Contributor

quozl commented May 8, 2021

I guess I'm still confused. Are you searching activities or Journal objects?

@chimosky
Copy link
Member Author

I guess I'm still confused. Are you searching activities or Journal objects?

Searching for activities in the journal.

@quozl
Copy link
Contributor

quozl commented May 12, 2021 via email

@Vishalk91-4
Copy link

@quizol is this issue open still
For me to work on

@quozl
Copy link
Contributor

quozl commented Dec 4, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants