Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Darkmode #3838

Open
Thund3rHawk opened this issue Mar 26, 2024 · 2 comments
Open

Adding Darkmode #3838

Thund3rHawk opened this issue Mar 26, 2024 · 2 comments

Comments

@Thund3rHawk
Copy link
Contributor

Thund3rHawk commented Mar 26, 2024

Current Behavior

Implement dark mode feature for enhanced user experience, enhancing accessibility and reducing eye strain. Enhance UI readability and comfort.

Desired Behavior

Dark mode should switch interface colors to darker shades, ensuring readability, reducing eye strain, and improving user experience in low-light conditions while maintaining visual clarity and accessibility.

Screenshot

Screenshot 2024-03-26 at 11 48 19 PM

Implementation

Implement a toggle button that switches between light and dark modes. Utilize JavaScript to update CSS classes dynamically, altering color schemes based on user preference.

Environment

  • Operating System: [e.g., Windows, macOS, Linux]
  • Browser (if applicable): [e.g., Chrome, Firefox, Safari]
  • Version of Software/Project: [e.g., v1.0.0]

Checklist

  • [Y] I have read and followed the project's code of conduct.
  • [Y] I have searched for similar issues before creating this one.
  • [Y] I have provided all the necessary information to understand and reproduce the issue.
  • [Y] I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@Bengowang
Copy link

I've attempted to complete this addition with my colleague but have run into some roadblocks. Since neither of us are very familiar with the code base we haven't been able to figure out all of the functions and facets that influence background color. Is anyone knowledgeable on what the hierarchy for what determines background color?

@Bengowang
Copy link

Update: We've made some headway in figuring out how the darkmode implementation is going to work, we just need some info now.
Screenshot 2024-04-15 210702
So, in this screenshot, I'm not sure what this circled area is called but I need to know because it is an overlay of the overall page background. In order to implement dark mode, we need to be able to apply it to both the background and whatever the overlay is. Can someone tell me what it's called and where in the code it is?
Thanks.

Bengowang pushed a commit to Bengowang/darkmode that referenced this issue Apr 26, 2024
…rlabs#3838 and updated Tone.js to use AudioWorklet Node according to Issue sugarlabs#3555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants