Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample widget improvements #3806

Open
pikurasa opened this issue Mar 8, 2024 · 2 comments · May be fixed by #3813
Open

Sample widget improvements #3806

pikurasa opened this issue Mar 8, 2024 · 2 comments · May be fixed by #3813
Labels
Component-Widget relating to a widget Issue-Enhancement

Comments

@pikurasa
Copy link
Collaborator

pikurasa commented Mar 8, 2024

Current Behavior

Currently, when you initiate the sample widget, you get an option to upload a sample. This is nice, but it requires a few extra steps from the students.

Desired Behavior

Add a button and simple interface to the modal window to record a sample directly from the browser. It should have options to record, playback recorded sound, and re-record a sample (directly from the browser).

Screenshots / Mockups

I don't yet have a mockup, but this is what it looks like now:

Screenshot from 2024-03-08 13-21-14

Acceptance Tests

Users should be able to record a new sample via their browser, without having to upload from their filesystem.
@Vasant18
Copy link

unable to reproduce the behavior, cannot find the sample widget , instead there is simple tuplet block in the widgets
image

@Mubashirshariq Mubashirshariq linked a pull request Mar 11, 2024 that will close this issue
Open
@pikurasa
Copy link
Collaborator Author

@Vasant18 It's an advanced mode block, which means you need to:

  1. Click the hamburger menu in the top-right of the screen
  2. Click on the start
  3. Click on the hyperlink that appears at center that tells you to refresh your browser to start again in advanced mode
  4. You should now be in advanced mode

Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-Widget relating to a widget Issue-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/add record button and playback button in sampler widget Mubashirshariq/musicblocks
2 participants
@pikurasa @Vasant18