Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate bounding boxes in brick path utility #341

Open
9 tasks done
meganindya opened this issue Jun 26, 2023 · 2 comments · Fixed by #354
Open
9 tasks done

Calculate bounding boxes in brick path utility #341

meganindya opened this issue Jun 26, 2023 · 2 comments · Fixed by #354
Assignees
@niloysikdar
Labels
gsoc Prospective task for GSoC

Comments

@meganindya
Copy link
Member

meganindya commented Jun 26, 2023 •
edited by niloysikdar

Description

Currently, the path utility in code-builder/src/brick/design0/utils/path.ts doesn't return the correct extents and co-ordinates data.

Objectives

  • Return data for all bounding boxes
    • bBoxBrick
    • bBoxNotchArg
    • bBoxNotchInsTop
    • bBoxNotchInsBot
    • bBoxNotchInsNestTop
    • bBoxArgs
  • Add a flag in the brick components, enabling which draws the bounding boxes (rectangles of different outline colours) over the bricks, to visually verify the calculations are correct
  • Complete it.todo tests in path.spec.ts
@meganindya meganindya mentioned this issue Jun 29, 2023
Merged
@niloysikdar niloysikdar added the gsoc Prospective task for GSoC label Jul 2, 2023
@meganindya meganindya changed the title Complete unfinished parts in brick path utility Calculate bounding boxes in brick path utility Jul 3, 2023
@niloysikdar niloysikdar mentioned this issue Jul 12, 2023
Merged
10 tasks
@niloysikdar niloysikdar linked a pull request Jul 12, 2023 that will close this issue
Implement extent and coords for the args and notches #354
Merged
10 tasks
@niloysikdar
Copy link
Member

@meganindya, I think we can close it as it got completed.

@hackorlyf
Copy link

@niloysikdar @meganindya Is it a resolved issue or can I work on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
gsoc Prospective task for GSoC
Projects
Music Blocks (v4) Code Builder
Status: 🛠️ In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement extent and coords for the args and notches sugarlabs/musicblocks-v4
3 participants
@meganindya @niloysikdar @hackorlyf