-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release V4 #9
Release V4 #9
Conversation
The activity does not stop running. Confirmed by executing it from terminal with sugar-activity3 To reproduce - Choose a game of 2 or 3 or 4 players from crazyeights box. Now click the stop button. The activity doen't stop execution.
Also yes photo() plays a important role it helps in customising deck appearance. |
99341ae
to
25213cf
Compare
|
Also I am sorry in advance, as I dont exactly know how some files like news etc are being edited so havent looked at them or how exactly version is changed, worked on this PR as all the issues can be solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit message says Removed redundant self.running
checks as in GUI interactions but there's no removal of any check instead there's removal of assignments.
Also avoid using ticks in git commit messages as git doesn't do any markdown formatting, you can use that in GH comments.
Assignment:
Checks:
Well I am unsure on the part because I took the sense of whole loop though if you want can change that to assignments. |
Yes changes the commit message , Thanks!! |
* Removed redundant "self.running" Assignments in GUI interactions. * Streamlined event handling to reduce excessive processing.
* If the camera is unavailable, display "Camera Not Found" in red. * Include instruction to "Click on Deck Button" to guide users.
I guess then news can be updated later lets say when version 5 is launched with several other updates etc? @chimosky |
The news file is updated as part of the release because that's what tells you what changed in that particular release. |
Branch seem to have conflicts, Closing Thanks. |
Special Thanks to @JuiP
Kindly review @walterbender @chimosky @quozl .
For reference see the pr #5
Errors raised by @chimosky and @quozl are addressed.
This close #7.
This close #6.