Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release V4 #9

Closed
wants to merge 9 commits into from
Closed

Conversation

Ovalelephant35
Copy link

@Ovalelephant35 Ovalelephant35 commented Apr 20, 2024

  • Stop Button Working
  • Race Condition Handled
  • Readme Added
  • Pot File initiated
  • V4

Special Thanks to @JuiP

  • Handled camera not found
  • Handled Error Event Queue Full
  • Added .flake8

Kindly review @walterbender @chimosky @quozl .
For reference see the pr #5
Errors raised by @chimosky and @quozl are addressed.

This close #7.
This close #6.

JuiP and others added 7 commits August 7, 2020 12:56
The activity does not stop running. Confirmed by executing it from terminal with sugar-activity3
To reproduce - Choose a game of 2 or 3 or 4 players from crazyeights box. Now click the stop button. The activity doen't stop execution.
@Ovalelephant35
Copy link
Author

Also yes photo() plays a important role it helps in customising deck appearance.

@Ovalelephant35
Copy link
Author

  • Handled the error event queue full, hopefully commit message provides with insight what actually is done there.
  • Coming to camera not found, centered the message and guided the user to click on deck button instead to use photo from journal or some already inbuild photos in absence of camera.

@Ovalelephant35
Copy link
Author

Ovalelephant35 commented Apr 23, 2024

Also I am sorry in advance, as I dont exactly know how some files like news etc are being edited so havent looked at them or how exactly version is changed, worked on this PR as all the issues can be solved.

Copy link
Member

@chimosky chimosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit message says Removed redundant self.running checks as in GUI interactions but there's no removal of any check instead there's removal of assignments.

Also avoid using ticks in git commit messages as git doesn't do any markdown formatting, you can use that in GH comments.

@chimosky
Copy link
Member

chimosky commented Apr 23, 2024

Reviewed 25213cf , not tested.

We have a maintainer checklist you should go through if you haven't.

This doesn't close #2, I'll upload the activity to weblate after this is merged.

@Ovalelephant35
Copy link
Author

Ovalelephant35 commented Apr 23, 2024

Your commit message says Removed redundant self.running checks as in GUI interactions but there's no removal of any check instead there's removal of assignments.

Also avoid using ticks in git commit messages as git doesn't do any markdown formatting, you can use that in GH comments.

Assignment:

  • In the run() method's initialization, self.running is set to True to start the game loop.

Checks:

  • The game loop runs while self.running is True.
  • When the game should exit (e.g., on pygame.QUIT), self.running is set to False, stopping the loop.
  • The code checks self.running to break out of the loop if it's False.
  • So, self.running is used to control the loop's execution by assigning a value (True to start, False to stop) and checking it to determine whether to continue or exit the loop.

Well I am unsure on the part because I took the sense of whole loop though if you want can change that to assignments.

@Ovalelephant35
Copy link
Author

Ovalelephant35 commented Apr 23, 2024

Yes changes the commit message , Thanks!!
Removed issue 2.

* Removed redundant "self.running" Assignments in GUI interactions.
* Streamlined event handling to reduce excessive processing.
* If the camera is unavailable, display "Camera Not Found" in red.
* Include instruction to "Click on Deck Button" to guide users.
@Ovalelephant35
Copy link
Author

I guess then news can be updated later lets say when version 5 is launched with several other updates etc? @chimosky

@chimosky
Copy link
Member

chimosky commented May 4, 2024

I guess then news can be updated later lets say when version 5 is launched with several other updates etc? @chimosky

The news file is updated as part of the release because that's what tells you what changed in that particular release.

@Ovalelephant35
Copy link
Author

Branch seem to have conflicts, Closing Thanks.

@Ovalelephant35 Ovalelephant35 deleted the alpha branch May 5, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity does not quit after pressing Stop button Create Readme.
3 participants