Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add game instructions & help button #13

Closed
wants to merge 1 commit into from

Conversation

Ovalelephant35
Copy link

  • Provided concise instructions for three game types.
  • Implemented a help button for player guidance.

This closes #8

Kindly review @walterbender @chimosky @quozl .

@Ovalelephant35
Copy link
Author

Made the instruction more clear and informative and also made it based on level name that for what level what has to be done.
Thanks kindly see.

@Ovalelephant35
Copy link
Author

Fixed the flake8 that were generated due long lines in the pr.

Copy link
Member

@chimosky chimosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gamehelp and helpbutton can be one file.

@Ovalelephant35
Copy link
Author

Ovalelephant35 commented Apr 24, 2024

I'm unsure if merging the files is the right choice because helpbutton.py is copied and has a different author (mentioned in the file), while gamehelp.py is the file I wrote. I'd prefer to keep them separate.
I have credited the author in commit message also.

@chimosky
Copy link
Member

I'm unsure if merging the files is the right choice because helpbutton.py is copied and has a different author (mentioned in the file), while gamehelp.py is the file I wrote. I'd prefer to keep them separate. I have credited the author in commit message also.

The license gives you the ability to modify the code and share, which is what you've done and that's not an issue, you can claim a copyright on your changes if you want.

Merging the files make sense as one imports the other and they both share a common goal, so no need to keep them separate.

* Provided concise instructions for three game types.

* Implemented a help button for player guidance.
  Credits : Gonzalo Odiard <godiard@gmail.com>.
@Ovalelephant35
Copy link
Author

Merged Files!

@chimosky
Copy link
Member

chimosky commented May 4, 2024

Tested 4e7f6ce, you should drop the numbers in the help message.

@Ovalelephant35
Copy link
Author

Yes, there seem to some problem with wordings as well I think its not clear enough.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add help instructions
2 participants