Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expiring notes (suggested by TheMatjaz#8264) #542

Open
candroid-man opened this issue Apr 23, 2022 · 3 comments · May be fixed by #2387
Open

Expiring notes (suggested by TheMatjaz#8264) #542

candroid-man opened this issue Apr 23, 2022 · 3 comments · May be fixed by #2387
Assignees
@alihamuh
Labels
good first issue Type: Feature Request New feature or request

Comments

@candroid-man
Copy link
Collaborator

Feature Request

By that I mean setting a time-to-live to a note, so it's moved to trash automatically afterwards. Would be useful for temporary notes like grocery lists, which become useless anyway after a week or two. I tend to forget about deleting such notes.

Personal Opinion

This sounds extremely useful, especially if it was paired with another feature; a dedicated spot for temporary notes in the app. Like a folder or tag, and if you create a note using the widget or maybe in the future using a quick settings tile on Android, it would be default be put into temporary notes, and you can change the location whilst creating the note if you want it somewhere else.
@ammarahm-ed
Copy link
Collaborator

Great idea!

@thecodrr
Copy link
Contributor

thecodrr commented Apr 8, 2023

Let's add this. How it'll work:

Core:

  1. We'll add a new property in the note object called expiryDate.
  2. We'll also need a cleanup method in the Notes collection that cleans up all the expired notes
  3. We will call the cleanup method after the Notes collection has initialized

Web:

  1. There will be a new item in note properties context menu called "Set expiry"
  2. Clicking on it will open a context menu with some preset values like 1 day, 1 week etc and it'll also have a last option called Custom. Clicking on Custom will open a dialog with a number counter. The number counter represents the number of days after which the note will be removed.
  3. We'll also add a new task in the scheduler that will run every 24 hours and call the cleanup function from the Core.

Mobile:

  1. There will be a new button in note properties action sheet called "Set expiry"
  2. Clicking on it will open a sheet which will have a few defaults and also a way to set a custom number of days.

@thecodrr thecodrr assigned ammarahm-ed and unassigned ammarahm-ed Apr 8, 2023
@thecodrr thecodrr added the Type: Feature Request New feature or request label Apr 8, 2023
@alihamuh
Copy link
Collaborator

working on it

@alihamuh alihamuh self-assigned this Apr 11, 2023
@alihamuh alihamuh linked a pull request Apr 19, 2023 that will close this issue
Add support for expiring notes #2387
Open
@ammarahm-ed ammarahm-ed mentioned this issue Jun 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alihamuh alihamuh

Labels
good first issue Type: Feature Request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for expiring notes streetwriters/notesnook
4 participants
@thecodrr @alihamuh @ammarahm-ed @candroid-man