Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

[BUG] if isCheckpointingEnabled =false ,offset commit will not get a chance to trigger #496

Open
holmes07 opened this issue Jan 7, 2022 · 1 comment
Labels

Comments

@holmes07
Copy link
Contributor

holmes07 commented Jan 7, 2022

Describe the bug
if checkpoint not turn on,the offset will never got commit, when we restart the job it will consumer from earliest offset again
can i fix it like this ? by commit it peroid

At ReaderThread run() method
After emitRecord(message) is call
// auto commit if checkpoint is not enable
if (!isCheckpointingEnabled && (SystemClock.now() - ackPeroid > lastAckTime)) {
offset.put(topicRange, message.getMessageId());
metadataReader.commitCursorToOffset(offset);
lastAckTime = SystemClock.now();
}

@KevinyhZou
Copy link
Contributor

KevinyhZou commented Jan 10, 2022

hello, I also encounter this problem in flink job consumed pulsar topic. And I have made a pr to enable offset auto commit. you can look at it: #497

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants