Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result.dataset_id is miss-named and should not return the internal esgf record id #7

Open
stephenpascoe opened this issue Mar 20, 2013 · 0 comments

Comments

@stephenpascoe
Copy link
Owner

ESGF search records contain various ids. These include:

  • id: internal identifier so that SOLr can keep track of each record. Currently the instance_id + index node
  • drs_id: DRS identifier without the version number. Effectively an identifier for each dataset (including all versions and replicas)
  • master_id: The same as drs_id. I think this was created because of confusion about the purpose of DRS and drs_id. E.g. it's not clear whether a DRS identifier includes a version
  • instance_id: <master_id>.. I.e. the DRS including the version number

pyclient adds to this confusion be exposing the id as Result.dataset_id. This needs to be changed in some backward-compatible way. We need a sane naming scheme for identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant