Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dap_config option not working #4

Open
LucaCinquini opened this issue Jan 27, 2013 · 1 comment
Open

dap_config option not working #4

LucaCinquini opened this issue Jan 27, 2013 · 1 comment
Assignees
@stephenpascoe

Comments

@LucaCinquini
Copy link

It seems like the module logon.py always uses the static location DAP_CONFIG as opposed to the mutable field LogonManager.dap_config, with the result that the location of the file cannot be changed.
Also, it would be nice if the value dap_config=None would result in the file NOT being written at all, in case the package is used as a library to satisfy requests from multiple users.
@ghost ghost assigned stephenpascoe Jan 30, 2013
@LucaCinquini
Copy link
Author

Hi Stephen, I think this issue would be solved if the following line in logon.py:

230 with open(DAP_CONFIG, 'w') as fh:

was changed to:

230 with open(self.dap_config, 'w') as fh:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenpascoe stephenpascoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucaCinquini @stephenpascoe