Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove transaction progress from send flow #20079

Closed
wants to merge 1 commit into from
Closed

fix: remove transaction progress from send flow #20079

wants to merge 1 commit into from

Conversation

OmarBasem
Copy link
Member

fixes: #20067

Summary

This PR removes transaction progress screen from the send flow.

Demo

Screen_Recording_20240517_114826_Status.mp4

@OmarBasem OmarBasem self-assigned this May 17, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 17, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 17, 2024 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b311c8b #1 2024-05-17 07:55:49 ~4 min tests 📄log
✔️ b311c8b #1 2024-05-17 07:57:23 ~5 min android-e2e 🤖apk 📲
✔️ b311c8b #1 2024-05-17 07:58:59 ~7 min android 🤖apk 📲
✔️ b311c8b #1 2024-05-17 08:00:09 ~8 min ios 📱ipa 📲

@J-Son89
Copy link
Member

J-Son89 commented May 17, 2024

sorry seems like we did some duplicate work.

I have this pr: #19984

which also handles swapping the tab to activity on that page change too. How do you think we should go forward?

@OmarBasem
Copy link
Member Author

OmarBasem commented May 17, 2024 •
edited

sorry seems like we did some duplicate work.

I have this pr: #19984

which also handles swapping the tab to activity on that page change too. How do you think we should go forward?

@J-Son89 No problem I can close mine.

@OmarBasem OmarBasem closed this May 17, 2024
Pipeline for QA automation moved this from REVIEW to DONE May 17, 2024
@J-Son89
Copy link
Member

J-Son89 commented May 17, 2024

sorry seems like we did some duplicate work.
I have this pr: #19984
which also handles swapping the tab to activity on that page change too. How do you think we should go forward?

@J-Son89 No problem I can close mine.

Just a note, when fixing additional things in a PR it's good to open an issue for visibility to avoid duplicates 👍

Thanks @OmarBasem - will do. There was an issue for it already:
#19519
Perhaps just not named accurately enough for it 🤔

@OmarBasem
Copy link
Member Author

sorry seems like we did some duplicate work.
I have this pr: #19984
which also handles swapping the tab to activity on that page change too. How do you think we should go forward?

@J-Son89 No problem I can close mine.
Just a note, when fixing additional things in a PR it's good to open an issue for visibility to avoid duplicates 👍

Thanks @OmarBasem - will do. There was an issue for it already: #19519 Perhaps just not named accurately enough for it 🤔

@J-Son89 Yeah just saw it, no worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smohamedjavid smohamedjavid Awaiting requested review from smohamedjavid

@J-Son89 J-Son89 Awaiting requested review from J-Son89

@BalogunofAfrica BalogunofAfrica Awaiting requested review from BalogunofAfrica

@mmilad75 mmilad75 Awaiting requested review from mmilad75

@seanstrom seanstrom Awaiting requested review from seanstrom

@clauxx clauxx Awaiting requested review from clauxx

@briansztamfater briansztamfater Awaiting requested review from briansztamfater

Assignees

@OmarBasem OmarBasem

Labels
request-manual-qa
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending page displayed after confirming transaction in bridging/collectibles sending/tokens sending flows
3 participants
@OmarBasem @status-im-auto @J-Son89