Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details overlapping on Wallet Send screen #20039

Closed
mariia-skrypnyk opened this issue May 15, 2024 · 6 comments · Fixed by #20102
Closed

Details overlapping on Wallet Send screen #20039

mariia-skrypnyk opened this issue May 15, 2024 · 6 comments · Fixed by #20102
Assignees
Labels
android E:Mobile Bug MVP E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Send Page MVP all issues for the send page of the wallet

Comments

@mariia-skrypnyk
Copy link

mariia-skrypnyk commented May 15, 2024

Bug Report

Expected behavior

https://www.figma.com/design/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?node-id=220-148036&t=qIeoFmxPkmCAMFt1-0

Screenshot 2024-05-15 at 14 51 59

Actual behavior

Screenshot 2024-05-15 at 14 48 54

Full page
Screenshot 2024-05-15 at 13 33 13

Reproduction

  1. Install app
  2. Login to app as user with a balance
  3. Go to wallet
  4. Send some tokens to another user

Additional Information

  • Status version: nightly 15/05
  • Operating System: Android
  • Device: Samsung A34 (14.0)
@mariia-skrypnyk mariia-skrypnyk added android E:Mobile Bug MVP E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Send Page MVP all issues for the send page of the wallet labels May 15, 2024
@OmarBasem
Copy link
Member

@J-Son89 we currently display the address instead of the user's name. Is displaying the user's name out of scope?

@J-Son89
Copy link
Member

J-Son89 commented May 17, 2024

Thanks @OmarBasem - it seems this page needs design input for smaller screens right (sorry if that's already mentioned)

I think we should have the page looking perfect for addresses, once that's all working we can add support for the account names, saved addresses and contacts etc.
I would say this part is lower priority though.

@J-Son89
Copy link
Member

J-Son89 commented May 17, 2024

Or is the designs 'recipient gets ...' because that is much easier and the address is already in two places on the page

@OmarBasem
Copy link
Member

@J-Son89 "Recipient gets ..." sounds good to me

@OmarBasem
Copy link
Member

OmarBasem commented May 17, 2024

@J-Son89 looking at the designs again, I am wondering what's the point of that part. Even what the recipient gets is already mentioned. I think displaying the time and max fees would be enough in that block

@J-Son89
Copy link
Member

J-Son89 commented May 17, 2024

Yeah that's true, can you raise this with design. It will help with the smaller screen issues too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android E:Mobile Bug MVP E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Send Page MVP all issues for the send page of the wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants