Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using profiles in REST integration tests #2440

Open
ivansenic opened this issue Feb 13, 2023 · 1 comment
Open

Avoid using profiles in REST integration tests #2440

ivansenic opened this issue Feb 13, 2023 · 1 comment
Assignees
Labels

Comments

@ivansenic
Copy link
Contributor

There are two integration tests in REST that test the same thing based on the properties:

  • RestApiV2QCqlDisabledIT
  • RestApiV2QCqlIT

The second one specifies a profile that sets stargate.rest.cql.disabled=false.

However, although this works on the integration tests, it fails when we are using the integration tests with the running app. Simply, you can not switch the properties of the running app. IN that sense, the integration tests, which are effectively end-to-end tests should not specify profiles.

I am not sure what's the best way to solve this. Imo the RestApiV2QCqlDisabledIT could be classical @QuarkusTest with concrete profile and check that method is not existing. For the other, we could enable by default in the test resources that the option is false and then have some kind of a protection in the situation when we run against the running app. Not sure though, maybe a small discussion on this should be done.

@tatu-at-datastax
Copy link
Collaborator

Ok. Yes, that makes sense. Just need to discuss the best way to refactor things to just verify 2 aspects (default being not to include; ability to include).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants