Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to a Junit extension for session management in GraphQL #2054

Open
olim7t opened this issue Sep 2, 2022 · 0 comments
Open

Switch back to a Junit extension for session management in GraphQL #2054

olim7t opened this issue Sep 2, 2022 · 0 comments

Comments

@olim7t
Copy link
Collaborator

olim7t commented Sep 2, 2022

Stargate v1 integration tests use a Junit 5 extension for tests that need the Java driver: CqlSessionExtension.

When I ported the GraphQL API to Quarkus, there was a point where getting the coordinator address was complicated from an extension, so I used a parent class instead: CqlEnabledIntegrationTestBase.

But the test infrastructure has evolved since then, and the address is now in a system property, easy to get from anywhere (via IntegrationTestUtils.getCassandraCqlAddress()). So it looks like CqlSessionExtension would be pretty easy to port after all.

This is a cleaner approach so we might want to take the extra effort to do it. But note that this is not high priority: the parent class approach works fine, and it's only used in the GraphQL API at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant