Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse values in the intermediate representation #6

Open
Nfsaavedra opened this issue May 20, 2022 · 1 comment
Open

Parse values in the intermediate representation #6

Nfsaavedra opened this issue May 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Nfsaavedra
Copy link
Member

We should parse the values in the intermediate representation allowing to differ, for instance, types (booleans, strings, numbers...) and expressions (ands, ors ...). This parsing would allow to define other type of smells in a more accurate way. For instance, imagine the smell "Hard-coded secret". We have something like: $test | "hello". Although a variable is present, there is still a chance that the secret is hard-coded.

@Nfsaavedra
Copy link
Member Author

Here, it would be important if a reference to the same variable pointed to the same object. We probably would need to implement the concept of scope.

@Nfsaavedra Nfsaavedra added the enhancement New feature or request label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant