Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UI Mode behave incorrectly on macOS #3570

Open
1 task done
lucydodo opened this issue Feb 20, 2024 · 11 comments
Open
1 task done

[Bug]: UI Mode behave incorrectly on macOS #3570

lucydodo opened this issue Feb 20, 2024 · 11 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs. gui macOS

Comments

@lucydodo
Copy link
Member

What did you do?

We've seen some issues with 'Dark Mode' recently, so I tested for all cases of UI settings in macOS and in our app.

What did you expect to see?

Consistent UI experience

What did you see instead?

App UI Setting macOS UI Setting Screenshot
Auto Light Screenshot 2024-02-20 at 19 24 27
Light Light Screenshot 2024-02-20 at 19 24 33
Dark Light Screenshot 2024-02-20 at 19 24 39
Auto Dark Screenshot 2024-02-20 at 19 25 02
Light Dark Screenshot 2024-02-20 at 19 25 08
Dark Dark Screenshot 2024-02-20 at 19 25 12

I think (but haven't checked the code flow yet) that if user set it to 'Follow the desktop UI', the UI changes are made by the Qt framework, and if user select the 'Light' or 'Dark' option, the changes are made by the other stylesheet.

DB4S Version

3.13.99 (nightly)

What OS are you seeing the problem on?

MacOS

OS version

macOS 14.3.1 (23D60)

Relevant log output

No response

Prevention against duplicate issues

  • I have searched for similar issues
@lucydodo lucydodo self-assigned this Feb 20, 2024
@lucydodo lucydodo added bug Confirmed bugs or reports that are very likely to be bugs. gui macOS labels Feb 20, 2024
@justinclift
Copy link
Member

Oh that looks weird. We have two different dark modes.

Wonder if that's a "feature" rather than a bug? 😉

(not really, it's definitely a bug)

@lucydodo
Copy link
Member Author

Yes, it's not what we intended anyway, so I guess it's a 'bug'. I'll try to check how it works on other operating systems first.

@rafrafek
Copy link
Contributor

In my case there is a glitch with an element displaying in light theme:

image

@rafrafek
Copy link
Contributor

All new tabs are named S... and it also looks like a glitch:

image

@justinclift
Copy link
Member

@rafrafek Does that S... problem still show up if you resize the window to be wider?

I'm still thinking it's a bug though. Am just wondering. 😄

@rafrafek
Copy link
Contributor

Yep, still there after resizing

image

@justinclift
Copy link
Member

k. Sounds like we might need to add some code that manually changes the width of the tab titles to be longer. 😄

@rafrafek
Copy link
Contributor

I forgot to mention I'm on 3.12.2, so the behavior may be different on the master branch. I'll try to test the master branch tomorrow.

@chrisjlocke
Copy link
Member

The s... tab name was recently brought up in discussions (#3548)
I don't see this on Windows.

@rafrafek
Copy link
Contributor

Same thing on both 3.12.2 and on the latest build:

image

@mgrojo
Copy link
Member

mgrojo commented Mar 22, 2024

The screenshots in @lucydodo's description look good to me. It's working as designed :)
Glitchs reported by @rafrafek are another matter. They should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs. gui macOS
Projects
None yet
Development

No branches or pull requests

5 participants