Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues with DB4S and CI workflow #1688

Open
chrisjlocke opened this issue Dec 25, 2018 · 26 comments
Open

Known issues with DB4S and CI workflow #1688

chrisjlocke opened this issue Dec 25, 2018 · 26 comments

Comments

@chrisjlocke
Copy link
Member

chrisjlocke commented Dec 25, 2018

This issue is for tracking all known issues with DB Browser for SQLite (DB4S) and our CI workflow.
It will show you what to expect when using and/or building DB4S. (Include continuous and nightly build)

It is meant to let you know that we are aware of these issues, but there are no fixes for them at the moment.
Either because the fix is out of our control (e.g. It is a problem with a library we use and
an issue with GitHub Actions restrictions or polices) or we haven't figured out a way (yet!) to fix them. 😃

Ideas, solutions, and PRs are always welcome.

DB4S (Application-level)

Error message: The root CA certificate is not trusted for this purpose (macOS only)

This is a known (minor) issue on macOS when trying to connect to DBHub.io via DB4S.
We're looking into it, and it's being tracked here: #2829

CI workflow

No code signing for Windows builds

We recently started relying on SignPath for code-signing for our Windows builds. SignPath doesn't yet support GitHub Actions, so we're using AppVeyor, and we're trying to figure out how to properly integrate the two.

We hope to have this resolved soon, but we're taking a little more time to prepare for the next release.
We hope to have the integration in 24.Q1 (Attn: @lucydodo) Thank you for understanding. :)

@karim
Copy link
Member

karim commented Feb 10, 2019

@chrisjlocke I'm just wondering why did you unpinn this issue? Is it okay to pin it back again?

@justinclift
Copy link
Member

It was probably unpinned because we worked around the Qt issue by changing to Qt 5.11.3 for our nightly builds, and the OpenSSL 1.1 thing also only affects people compiling it themselves too.

The Wifi problem potentially affects more people, so just now pinned it back. Good suggestion. 😄

@karim
Copy link
Member

karim commented Feb 11, 2019

I see, thanks.

We should keep this one open and pinned to list the things that are out of our control and things we cannot really fix, but maybe provide a workaround till they are fixed by the affected library.

@justinclift justinclift changed the title Known issues with DB4S Known issues when compiling with DB4S Feb 18, 2019
@justinclift justinclift changed the title Known issues when compiling with DB4S Known issues when compiling DB4S Feb 18, 2019
@justinclift
Copy link
Member

justinclift commented Feb 18, 2019

Just removed the WiFi entry, as the fix is now in our most recent release (3.11.1). Also updated the title to mention "when compiling" as both of the remaining issues are developer only items (at this point). Naturally, this can be changed around later depending if/what/how/when/where (etc) new significant issues show up. 😄

@karim
Copy link
Member

karim commented Feb 20, 2019

Good point on removing the WiFi part since it is fixed now. 👍

I think we should split the first post into two sections; when using and the other when compiling DB4S.

I see that the dark mode/theme does not work as intended. Many issues are opened for that. On macOS and Windows 10, right?

Should this be noted here as well since this is a Qt thing we cannot do anything about, and so that we can close all new issues about it with a link to this issue?

@justinclift
Copy link
Member

justinclift commented Feb 20, 2019

Oh yeah, good approach. I'm about to get off the computer, so feel free to get that done if you want.

@karim karim changed the title Known issues when compiling DB4S Known issues with DB4S Feb 21, 2019
@GortiZ6
Copy link
Contributor

GortiZ6 commented Jun 4, 2019

Long time no see... sorry! Anyway I've tried to build the latest git with Qt 5.12.3..
immagine
Is this really solved or it's again just me testing it in the wrong way?

@justinclift
Copy link
Member

Oh cool, looks like it might be solved now after all! 😄

@chrisjlocke
Copy link
Member Author

chrisjlocke commented Jun 4, 2019 via email

@GortiZ6
Copy link
Contributor

GortiZ6 commented Jun 4, 2019

I enlarged the line to test. This is with the standard 1 line height:
image

@chrisjlocke
Copy link
Member Author

chrisjlocke commented Jun 4, 2019 via email

@justinclift
Copy link
Member

I'll update the Qt version on our nightly build server VMs over the next few days. 😄

@mgrojo
Copy link
Member

mgrojo commented Jun 4, 2019

It should also do automatic word wrapping when the line is very long and has embedded spaces.

EDIT: Sorry, I see now in the screenshot that "a really long line divided" has been word wrapped. So it works!

@justinclift
Copy link
Member

Looks like your bug report was worth the effort @mgrojo. 😁

@GortiZ6
Copy link
Contributor

GortiZ6 commented Jun 5, 2019

@mgrojo yes, I can confirm also a single line is properly word wrapped. This was windows and I've not checked yet for Linux, but Qt should behave the same on every platform, so your bug report seems was accepted and fixed ;)

@MKleusberg
Copy link
Member

What do you think? Can we close this issue? Both issues regarding dark mode are closed and I believe the macOS problem should be gone since we notarize our builds.

@chrisjlocke
Copy link
Member Author

Yes, I think it was just a 'general place' for any issues that were show-stopppers...

@justinclift
Copy link
Member

Cool, closing this then and unpinning it. 😄

@justinclift justinclift unpinned this issue May 22, 2021
@chrisjlocke chrisjlocke pinned this issue Oct 14, 2022
@lucydodo
Copy link
Member

@chrisjlocke Is there a reason pinned it again? 🤔

@chrisjlocke
Copy link
Member Author

Yes, it was unpinned, but Justin wanted to add to it, and couldn't find it, so I pinned it again, and then he found it, then he edited it. The last part in it is current.

@lucydodo
Copy link
Member

@chrisjlocke oh, I got it. Thanks for response. 😄

@lucydodo
Copy link
Member

and one more, how about you think reopen this issue?

@justinclift justinclift reopened this Dec 3, 2022
@justinclift
Copy link
Member

@lucydodo Good idea. 😄

@lucydodo
Copy link
Member

Hi @chrisjlocke, Do you mind if I edit the content of this issue a bit?

Our CI workflow sometimes fails. If the CI workflow fails for a particular commit or PR, I can leave a comment on the commit or PR to track and resolve the issue, but the downside is that if it works on a schedule, like a nightly build, there is no place to leave a comment and I have to create a new issue or discussion.

Of course, I can email @justinclift privately to track and resolve the issue when disconnected from our build server,
but otherwise I want to track it together here. 😄

@justinclift
Copy link
Member

@lucydodo You don't need to ask, you're welcome to do it. 😄

@lucydodo
Copy link
Member

Thank you, I was worried it might be rude to edit it arbitrarily. :)

@lucydodo lucydodo changed the title Known issues with DB4S Known issues with DB4S and CI workflow Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants