Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Clean up the Qt namespace and add the tests #465

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

PR: Clean up the Qt namespace and add the tests #465

wants to merge 11 commits into from

Conversation

StSav012
Copy link
Contributor

I've tried to resolve #463 in case it even needs resolving.

Some changes are tricky and require further testing. Namely, please pay attention to QApplication.exec_ and QMenu.exec_ functions when they're patched. My local tests reveal no problems, but…

@StSav012 StSav012 marked this pull request as ready for review October 27, 2023 14:09
@ccordoba12 ccordoba12 mentioned this pull request Oct 31, 2023
Open
@coveralls
Copy link

coveralls commented Nov 1, 2023 •
edited

Coverage Status

coverage: 42.329% (-0.3%) from 42.651% when pulling 1dcd69b on StSav012:clean-up-namespace into b3b222a on spyder-ide:master.

@coveralls
Copy link

coveralls commented Nov 1, 2023 •
edited

Coverage Status

coverage: 43.848% (+1.2%) from 42.651% when pulling 940030c on StSav012:clean-up-namespace into b3b222a on spyder-ide:master.

@StSav012
Fixed formatting
940030c 
I'm unhappy with the auto-fix.
@dalthviz dalthviz changed the title Clean up the Qt namespace and add the tests PR: Clean up the Qt namespace and add the tests Nov 1, 2023
@dalthviz dalthviz added this to the v2.5.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@StSav012 StSav012

Labels
type:Enhancement
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

Qt namespace is littered with service functions
3 participants
@StSav012 @coveralls @dalthviz