Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coronography unit test failures on Mac only #8465

Closed
stscijgbot-jp opened this issue May 7, 2024 · 2 comments · Fixed by #8490
Closed

coronography unit test failures on Mac only #8465

stscijgbot-jp opened this issue May 7, 2024 · 2 comments · Fixed by #8490

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3614 was created on JIRA by Ned Molter:

The test jwst/coron/tests/test_coron.py::test_align_array started showing 
AssertionError: Not equal to tolerance rtol=1e-07, atol=1e-06 a few days ago when GitHub Actions runs the unit test suite for MacOS py311.
 
The differences are pretty small: Max absolute difference: 9.8773848e-06, Max relative difference: 4.67009943e-05.  However, it would be good to figure out why this happened (e.g., a numpy/scipy release) and ensure that there are no qualitative differences to worry about here before simply increasing the tolerances.

@braingram
Copy link
Collaborator

See: #8440

The differences from the leastsq fit are relatively small. However the tolerances for the test had to be raised considerably (see #8439) due to how the test is calculated.

I had some hope that scipy dev fixed this (as there were other leastsq issues). However the last time I checked (sometime last week) the nightly version still caused this test to fail.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Fixed by #8490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants