Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NIRSpec detector temperature keywords #8423

Open
stscijgbot-jp opened this issue Apr 15, 2024 · 9 comments
Open

Add NIRSpec detector temperature keywords #8423

stscijgbot-jp opened this issue Apr 15, 2024 · 9 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3596 was created on JIRA by Melanie Clarke:

In order to generate new darks, biases, masks, and readnoise files for use in the calibration pipeline, we need some more information about detector temperature to be stored in the MAST uncal files.

Historically, these files were created from custom products generated with ESA commissioning code.  These contain detector temperature keywords used to select suitable dark files for combination (T_ASIC1 and T_ASIC2).  These values come from EDB mnemonics: 
T_ASIC1 = IGDP_NRSD_ALG_A1_TEMP
T_ASIC2 = IGDP_NRSD_ALG_A2_TEMP

The uncal files currently do not contain these keywords, or any other proxy values for detector temperature.  We'd like to request that these values be added to support NIRSpec calibration efforts.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

This request really needs to go to the JWST Keyword Dictionary review board, via a ticket in the JWSTKD project. If it gets approved and new keywords are added to the level-1b (uncal) products, Cal will then update our datamodels schemas to also include the new keywords.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Howard Bushouse I asked Melanie Clarke  to start with a JP ticket, figuring we can discuss at the Wednesday meeting and figure out where to go from there (KD tickets and any others).  Should we start with the KD ticket instead?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

David Law No, if you're already planning to discuss at a JP meeting, that's fine. We can file the JWSTKD ticket after that discussion, assuming no one completely vetos the idea during discussion.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Rosa Diaz on JIRA:

David Law yes, I think this should have been a keyword dictionary ticket instead as this is not a Cal pipe issue but rather needed to create the reference files.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Richard A. Shaw on JIRA:

Pinging Brian Charlow here too. If users want to search on this keyword in Portal or JWST, I believe search some changes will be needed on the MAST side.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Rosa Diaz on JIRA:

Howard Bushouse are you filing the JWSTKD ticket?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

This ticket should be considered as "On Hold" until the Keyword Dictionary review board makes a final decision on whether or not to have these keywords added, as opposed to having the team just use the available interface to the EngDB to get the temperature data for calibration exposures.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Rosa Diaz on JIRA:

I am waiting for Melanie to comeback from vacation and discuss this with the NIRSpec team

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Melanie Clarke on JIRA:

I discussed this issue with James Muzerolle Christian Hayes and Diane Karakla:

NIRSpec now has a workaround script that retrieves the correct dark data based on temperature values retrieved from the EDB.  It would be nice to have the values in the uncal headers, for confirmation and to make them searchable on MAST, but it is not a requirement for performing the necessary calibration work.  Since it is board policy not to add header keywords for this use case, we will withdraw this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant