Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support failed rows query in user defined metric check #2044

Open
sagarwal144 opened this issue Mar 22, 2024 · 2 comments
Open

Add support failed rows query in user defined metric check #2044

sagarwal144 opened this issue Mar 22, 2024 · 2 comments

Comments

@sagarwal144
Copy link

Currently, we don't have a way to specify the failed row query in the user defined metric. So when the user defined metric check fails, we are not able to collect the sample failed rows in either SODA Cloud or CustomSampler. This issue proposes to add failed row query section in the user defined metric as follows

- test_metric_query = 0:
      test_metric_query query: |
        SELECT count(*)
        FROM group_subs where start_date > end_date
      fail query: |
        SELECT id, start_date, end_date
        FROM group_subs where start_date > end_date
        LIMIT 5
@tools-soda
Copy link

SAS-3109

@benjamin-pirotte
Copy link

Hi, thanks for your request! This feature will added early May.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants