Oracle: support advanced connection parameters #1990
Comments
|
SAS-2721 |
|
I have made a pr that would solve this issue. |
vinod901
added a commit
to vinod901/soda-core
that referenced
this issue
Feb 12, 2024
m1n0
added a commit
that referenced
this issue
Feb 13, 2024
* Update oracle_data_source.py Accommodate the Oracle data source to connect with `host`, `port` and `service_name` passed to it as different properties in the soda config file. We can still pass `connectstring` property. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update oracle_data_source.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * this commit solves #1990 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Milan Lukac <m1n0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Oracle data source currently support basic connection parameters only. (see here)
Add parsing
connect_paramsattribute and pass all key/value pairs to the connect method, see docs here and here.The text was updated successfully, but these errors were encountered: