Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving dependency from extinction to dust_extinction #372

Open
benjaminrose opened this issue Jun 12, 2023 · 2 comments
Open

Comments

@benjaminrose
Copy link
Member

Do we want to moe to dust_extiction?

@benjaminrose
Copy link
Member Author

Ping, @jchiang87

@benjaminrose
Copy link
Member Author

Initially, dust_extinction has the required A_V dependent dust laws. We might want to do some clever import dust_extinction as ... to make the transition easier. Though this might not work since the APIs are very different for extinction and dust_extinction.

However, I am not sure what extinction.apply is, and I don't see this in dust_extinction.

return extinction.apply(extinction.ccm89(wave, ebv * r_v, r_v), flux)

It will take a bit more effort to track down what this bit of code is doing and see what needs to be done to move to dust_extinction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant