Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please check the cshtml files for BOM-Headers not at file start #1081

Open
Algorithman opened this issue May 3, 2024 · 0 comments
Open

Please check the cshtml files for BOM-Headers not at file start #1081

Algorithman opened this issue May 3, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@Algorithman
Copy link
Contributor

Algorithman commented May 3, 2024

Describe the bug
Just went over the whole order process again and I found a BOM-Header in the middle of ShippingAddress.cshtml (Pos 43).
Another cshtml file affected: TierPriceStore.cshtml (Pos 16).

Also present in: src\Smartstore.Modules\Smartstore.Stripe\wwwroot\public.scss (Pos 3)

Probably best to remove it with an hex editor since Visual Studio doesn't show it, even if it is a non-standard position for a BOM.

Why remove it?
It will create a output of &#xFEFF in the resulting html code. In case of the ShippingAddress.cshtml it will force a line break.

(Hex in files: EF BB BF)

@Algorithman Algorithman added the bug label May 3, 2024
@muratcakir muratcakir added this to the 5.2.0 milestone May 3, 2024
@muratcakir muratcakir self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants