ComboBox reset current on model changed #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
May 10, 2024
ogoffart
reviewed
May 10, 2024
CHANGELOG.md
Outdated
Comment on lines
34
to
35
| - Fixed updating model of ComboBox does not change current-value | ||
| - Fixed set current-index of ComboBox to -1 does not reset current-value |
There was a problem hiding this comment.
These actually belong in the Widget category.
Be carefull as well that if this is not merged before the release, it needs to be changed to a different version manually.
|
I tried to debug this a little. It’s the inlining that breaks with change handlers. SLINT_INLINING=true reproduces the failure also for builds (gallery for example). It looks like the names references inside the change handlers aren’t adjusted correctly. From the code it looks like that should happen when processing the fix ups for the mapping, but something goes wrong. |
|
Minimal reproducer: component Test {
in-out property <int> index: 0;
changed index => {
debug(root.index);
}
}
export component Testcase {
in-out property index <=> t.index;
t := Test {}
} |
|
Even smaller test case, it's not related to inlining but declarations moving: export component Testcase {
t := Rectangle {
in-out property <int> index: 0;
changed index => {
}
}
} |
When eliminating a properyt, also make sure to remove associated change callbacks:
```slint
export component Testcase {
t := Rectangle {
in-out property <int> index: 0;
changed index => {
}
}
}
```
When an observed property is renamed due to alias removal, make sure to update the name of the observed property:
```slint
export component Testcase {
in-out property index <=> t.index;
t := Rectangle {
in-out property <int> index: 0;
changed index => {
}
}
}
```
FloVanGH
force-pushed
the
florian/cb-model-change
branch
from
801a18f
to
77e318e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5214
Fixes #3628