Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the latest versions of esp-hal and slint are present simultaneously, a compilation error occurs #5057

Open
Song-aff opened this issue Apr 15, 2024 · 3 comments

Comments

@Song-aff
Copy link

When the latest versions of esp-hal and slint are present simultaneously, a compilation error occurs:

[dependencies]
esp-hal = { version = "0.16.1", features = ["esp32c3"] }
slint ={version = "1.5.1", default-features = false, features = [
    "compat-1-2",
    "unsafe-single-threaded",
    "libm",
    "renderer-software"]}

The error message is as follows:

cargo build
   Compiling portable-atomic v1.6.0
error: you may not enable feature `critical-section` and cfg(portable_atomic_unsafe_assume_single_core) at the same time
   --> /Users/admin/.cargo/registry/src/mirrors.tuna.tsinghua.edu.cn-df7c3c540f42cdbd/portable-atomic-1.6.0/src/lib.rs:409:1
    |
409 | / compile_error!(
410 | |     "you may not enable feature `critical-section` and cfg(portable_...
411 | | );
    | |_^

error: could not compile `portable-atomic` (lib) due to 1 previous error
@Song-aff
Copy link
Author

esp-rs/esp-hal#1434 (comment)
I also raised this question in ESP-HAL

@ogoffart
Copy link
Member

Looks like we shouldn't unconditionally require critical-section in

portable-atomic = { version = "1", features = ["critical-section"] }
and maybe also in once_cell, but we then need to enable it in some case. I wonder what's best here.

@KortanZ
Copy link

KortanZ commented May 12, 2024

Any plan to fix this? It's really annoying that need to patch esp-hal as a workaround in order to use slint. Really thankful if this could be fixed 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants