Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search function not finding results #1663

Open
smhanov opened this issue Sep 19, 2022 · 3 comments
Open

Search function not finding results #1663

smhanov opened this issue Sep 19, 2022 · 3 comments
Labels

Comments

@smhanov
Copy link

smhanov commented Sep 19, 2022

Bug Description
Under an older version (slate 2.3.1) typing "userec" into the page at https://zwibbler.com/docs finds the single result "useRectangleTool". Under the latest version, as we type, we get no results until "usere" and then we get many results, and when we add the character 'c' to get userec, we get no results again. You must type the complete "userectangletool" to get the result.

Screenshots
Old version:
image

New version:
image

Browser (please complete the following information):

  • OS: Ubuntu 22.04
  • Browser: Firefox
  • Version: 104.0.2

Last upstream Slate commit (run git log --author="\(Robert Lord\)\|\(Matthew Peveler\)\|\(Mike Ralphson\)" | head -n 1):
848d9ee

@MasterOdin
Copy link
Member

Probably a bug introduced in our usage of lunr.js when we went from 0.5.7 to 2.3.9 in slate 2.7.0.

@MasterOdin MasterOdin added the bug label Sep 19, 2022
@smhanov
Copy link
Author

smhanov commented Oct 6, 2022

I can confirm that version 2.6.1 works properly and the latest version does not.

Note if anyone is trying to reproduce it in zwibbler docs, I have reverted to that version (thanks docker!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants
@smhanov @MasterOdin and others