Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recalculate halo mass function test values #594

Open
3 tasks done
rrjbca opened this issue Jan 28, 2023 · 0 comments
Open
3 tasks done

Recalculate halo mass function test values #594

rrjbca opened this issue Jan 28, 2023 · 0 comments
Assignees
@rrjbca
Labels
bug Something isn't working high priority issues needing immediate attention module: halos tests
Projects
Dark Matter Halos

Comments

@rrjbca
Copy link
Contributor

rrjbca commented Jan 28, 2023 •
edited

#445 fixed a bug in the calculation of the Eisenstein & Hu matter power spectrum. This fix has now been merged into module/halos and is causing multiple unit tests and doctests to fail since they are calculating mass funtions and comparing them against values precomputed using the old bugged power spectrum module.

The following precomputed values need to be recomputed and updated:

Test failures can be seen here: https://github.com/skypyproject/skypy/actions/runs/4032155320
@rrjbca rrjbca added bug Something isn't working module: halos tests high priority issues needing immediate attention labels Jan 28, 2023
@rrjbca rrjbca added this to To do in Dark Matter Halos via automation Jan 28, 2023
@rrjbca rrjbca self-assigned this Jan 28, 2023
@rrjbca rrjbca mentioned this issue Jan 28, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrjbca rrjbca

Labels
bug Something isn't working high priority issues needing immediate attention module: halos tests
Projects
Dark Matter Halos
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rrjbca