Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Schechter sampler resolution should be a required argument #473

Open
rrjbca opened this issue Jul 13, 2021 · 0 comments
Open

ENH: Schechter sampler resolution should be a required argument #473

rrjbca opened this issue Jul 13, 2021 · 0 comments
Labels

Comments

@rrjbca
Copy link
Contributor

rrjbca commented Jul 13, 2021

We should consider making resolution a required argument of the schechter sampler and other functions that call it. Currently default values are being used throughout the library e.g. schechter_lf but a single fixed default value can lead to vastly different levels of numerical accuracy depending on the other parameters alpha, x_min and x_max. By requiring the user to choose the resolution we avoid them blindly using a default value that may be unsuitable for their use case and instead implicitly ask them to consider their own numerical requirements.

@rrjbca rrjbca added enhancement Improvement of existing feature module: galaxies module: utils labels Jul 13, 2021
@Lucia-Fonseca Lucia-Fonseca changed the title Schechter sampler resolution should be a required argument ENH: Schechter sampler resolution should be a required argument Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant