Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CNNClassifier and CNNRegressor do not accept filter_sizes argument listed in docstring #6436

Closed
narimanabdi opened this issue May 17, 2024 · 2 comments · Fixed by #6452
Closed

[BUG] CNNClassifier and CNNRegressor do not accept filter_sizes argument listed in docstring #6436

narimanabdi opened this issue May 17, 2024 · 2 comments · Fixed by #6452
Labels
bug Something isn't working module:classification classification module: time series classification module:regression regression module: time series regression
Projects
Bugfixing

Comments

@narimanabdi
Copy link

init method parameter error

In the CNNRegressor class, according to its docstring, there is a parameter termed "filter_sizes" to change the size of CNN filters. but when we want to initialize an object from this class with this parameter, the "unexpected keyword argument" error for init() method will be raised.
@narimanabdi narimanabdi added the bug Something isn't working label May 17, 2024
@fkiraly fkiraly added module:classification classification module: time series classification module:regression regression module: time series regression labels May 20, 2024
@fkiraly fkiraly changed the title [BUG]CNNRegressor unexpected keyword argument error for filter_sizes parameter [BUG] CNNClassifier and CNNRegressor do not accept filter_sizes argument listed in docstring May 20, 2024
@fkiraly fkiraly added this to Needs triage & validation in Bugfixing via automation May 20, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented May 20, 2024

This is indeed a bug, it should be passed on.

@fkiraly fkiraly mentioned this issue May 20, 2024
Merged
@fkiraly
Copy link
Collaborator

fkiraly commented May 20, 2024

Fix here: #6452

@fkiraly fkiraly moved this from Needs triage & validation to Under review in Bugfixing May 20, 2024
fkiraly added a commit that referenced this issue May 27, 2024
@fkiraly
[BUG] in CNNClassifier and CNNRegressor, ensure filter_sizes an…
adf99fd 
…d `padding` is passed on (#6452)

This PR adds `filter_sizes` and `padding` parameters to `CNNClassifier`
and `CNNRegressor`, and ensures these are passed on to `CNNNetwork`.

Fixes #6436.
Bugfixing automation moved this from Under review to Fixed/resolved May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module:classification classification module: time series classification module:regression regression module: time series regression
Projects
Bugfixing
Fixed/resolved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] in CNNClassifier and CNNRegressor, ensure filter_sizes and padding is passed on sktime/sktime
2 participants
@fkiraly @narimanabdi