[BUG] in CNNClassifier and CNNRegressor, ensure filter_sizes and padding is passed on
#6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:classification
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
yarnabrina
reviewed
May 20, 2024
|
Then, should we change the docstring to match actual argument order? We can add new arguments only at the end, without deprecation. I changed the docstrings now so the sequence of arguments is in line with the sequence in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
filter_sizesandpaddingparameters toCNNClassifierandCNNRegressor, and ensures these are passed on toCNNNetwork.Fixes #6436.