Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json1 SQLite extension is not correctly detected in versions.json #2326

Open
sebbacon opened this issue Apr 18, 2024 · 0 comments · May be fixed by #2327
Open

json1 SQLite extension is not correctly detected in versions.json #2326

sebbacon opened this issue Apr 18, 2024 · 0 comments · May be fixed by #2327

Comments

@sebbacon
Copy link

Due to hasversion always being False for json1, it is never detected in this code path:

datasette/datasette/app.py

Lines 1106 to 1115 in 7d6d471

for extension, testsql, hasversion in (
("json1", "SELECT json('{}')", False),
("spatialite", "SELECT spatialite_version()", True),
):
try:
result = conn.execute(testsql)
if hasversion:
sqlite_extensions[extension] = result.fetchone()[0]
else:
sqlite_extensions[extension] = None

sebbacon added a commit to sebbacon/datasette that referenced this issue Apr 18, 2024
@sebbacon sebbacon linked a pull request Apr 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant