Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

McListCall item_schema being incorrectly validated #492

Open
thebigmunch opened this issue Sep 1, 2016 · 2 comments
Open

McListCall item_schema being incorrectly validated #492

thebigmunch opened this issue Sep 1, 2016 · 2 comments

Comments

@thebigmunch
Copy link
Contributor

It appears that the responses are being successfully validated no matter if the item_schema matches or not. While testing this, I changed the item_schema of ListTracks to sj_station and ran Mobileclient.get_all_songs() without a ValidationException occurring.

There could be a number of schema changes that have been missed due to this bug. E.g. I found 15 or so changes/additions that needed to be made to sj_track after taking a closer look.

@simon-weber
Copy link
Owner

Nice find. I took a quick look through the history and have no clue what could have caused this (assuming that it worked at some point, which might not even be true?).

@thebigmunch
Copy link
Contributor Author

thebigmunch commented Sep 1, 2016

I took a quick look through validation-related issues, and they all appear to be from McCalls, not McListCalls. So it's entirely possible that it may not have ever worked properly. And all the changes/additions to sj_track were needed for ListTracks, not GetStoreTrack, which tracks with that possibility.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants