You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When creating a batch with 1 job and 3 retries, sidekiq will call on_complete callback anyways even job is failing on the first attempt. After 3 attempts failing job will be moved to a dead list. Counters for the batch will be: Job Count: 1 | Pending: 1 | Failed: 1
Poison pill scenario.
Suppose we have a job that crashes sidekiq. Same scenario with batch doesn't work now in this case. on_complete callback is never invoked as Failed counter is not incremented to 1 even though sidekiq + superfetch tried to recover this orphan 3 times and gave up moving it to dead list. Sidekiq before moving job to dead list should increment counters correctly and consider this job as failed otherwise batch is not closed correctly.
The text was updated successfully, but these errors were encountered:
We know that after n attempts the job is considered a poison pill and thus we move it to a dead list, isn’t it a good place to keep the counters up to date? In both scenarios the job is failing, but only one calls callback.
Ruby version: 2.7.8p225
Rails version: 6.1.5.1
Sidekiq / Pro / Enterprise version(s): 7.1.2
When creating a batch with 1 job and 3 retries, sidekiq will call
on_complete
callback anyways even job is failing on the first attempt. After 3 attempts failing job will be moved to a dead list. Counters for the batch will be:Job Count: 1 | Pending: 1 | Failed: 1
Suppose we have a job that crashes sidekiq. Same scenario with batch doesn't work now in this case.
on_complete
callback is never invoked as Failed counter is not incremented to 1 even though sidekiq + superfetch tried to recover this orphan 3 times and gave up moving it to dead list. Sidekiq before moving job to dead list should increment counters correctly and consider this job as failed otherwise batch is not closed correctly.The text was updated successfully, but these errors were encountered: