Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check / prove that integrator test is valid for temperature / pressure coupling #67

Open
ptmerz opened this issue Apr 28, 2020 · 1 comment
Assignees
Milestone

Comments

@ptmerz
Copy link
Member

ptmerz commented Apr 28, 2020

The integrator test analyzes the fluctuations of the constant of motion of a simulation. Theoretically, this is expected to be proportional to dt^2 (since the integrator preserves the constant of motion of the shadow Hamiltonian, but we are observing the constant of motion of the real Hamiltonian...).

We are only advertising to use this in NVE simulations, since we never cleanly proved that it would work with constants of motion of extended systems using temperature or pressure coupling. It shouldn't be too hard to check this & update the documentation accordingly.

@ptmerz ptmerz self-assigned this Apr 28, 2020
@ptmerz ptmerz added this to the Monday Mar 1 milestone Feb 15, 2021
@ptmerz ptmerz modified the milestones: Monday Mar 1, JOSS version Apr 29, 2021
@ptmerz ptmerz modified the milestones: JOSS version, Future Nov 4, 2021
@ptmerz
Copy link
Member Author

ptmerz commented Nov 4, 2021

Bumped since this isn't a blocking issue.

@ptmerz ptmerz closed this as completed Nov 4, 2021
@ptmerz ptmerz reopened this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant