Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"missing_pct" misnamed in simulate_genotype_call_dataset #1172

Open
hyanwong opened this issue Jan 19, 2024 · 0 comments
Open

"missing_pct" misnamed in simulate_genotype_call_dataset #1172

hyanwong opened this issue Jan 19, 2024 · 0 comments

Comments

@hyanwong
Copy link

simulate_genotype_call_dataset says:

missing_pct
The percentage of missing calls, must be within [0.0, 1.0], optional

But 0..1 isn't a percentage, it's a proportion or fraction. So I guess this should be renamed "missing_frac" or "missing_prop", (and maybe missing_pct could be deprecated but retained for backwards compatibility)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant