New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Optional Argument to sun() Function to Return Only Specified Keys #85

Open

qliu-bcs opened this issue Jan 13, 2023 · 0 comments

qliu-bcs commented Jan 13, 2023

Could we add an optional argument to the sun() function linked below for the users to specify key(s) to return?
https://github.com/sffjunkie/astral/blob/3.2/src/astral/sun.py#L1232
https://github.com/sffjunkie/astral/blob/3.2/src/astral/location.py#L225

e.g. If only "sunrise" and "sunset" are needed, we have the option to skip "dawn", "noon", and "dusk" calculation.

This could potentially improve performance by skipping non-needed calculation(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment