Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change queueLimit from infinity to prevent OutOfMemoryException #141

Open
mishamyte opened this issue Oct 11, 2022 · 6 comments
Open

Change queueLimit from infinity to prevent OutOfMemoryException #141

mishamyte opened this issue Oct 11, 2022 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@mishamyte
Copy link
Member

Now default value of queueLimit is infinity, which means if Loki would be unavailable, events in the memory will be appended until app will run our of memory (if Loki won't become available).

We should simplify change this value to something reasonable

@mishamyte mishamyte added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 11, 2022
@mishamyte mishamyte added this to the v9.0.0 milestone Oct 11, 2022
@mishamyte mishamyte self-assigned this Oct 11, 2022
@NielsPilgaard
Copy link

I'd like to have a go at solving this, would that be alright with you? 😃

@mishamyte
Copy link
Member Author

Hi @NielsPilgaard,

Main difficulty of this change is that it will change the default behavior. So it is a breaking change from the point of release management, so I've pointed it to the next major release. And I plan a lot of changes for v9, so I haven't touched it yet

@NielsPilgaard
Copy link

Ah fair enough 👍 If there's anything you need help with in that regard I'd love to pitch in if I can.

@mishamyte
Copy link
Member Author

Thank you!

I hope this would be done on base of v9 concept. I'm sorry, I postponed it a little because of some factors in my life, but I'm going to return to it in the nearest time)

@NielsPilgaard
Copy link

All good, looking forward to see v9 👍

@Mario-Hofstaetter
Copy link

Looking forward to this, just hit the infinite queueLimit, with > 2 GB of memory for retained logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Development

No branches or pull requests

3 participants