v9.0.0-beta7

[mivano]

What's Changed

• Create codeql-analysis.yml by @mivano in Create codeql-analysis.yml #370
• fix: Correct comment about default TypeName by @mikkelbu in fix: Correct comment about default TypeName #393
• Proper handling of TypeName = null from appsettings.json by @mariwing in Proper handling of TypeName = null from appsettings.json #420
• Add ElasticsearchSinkOptions.BufferFileRollingInterval option by @andrey-kozlov-skuvault in Add ElasticsearchSinkOptions.BufferFileRollingInterval option #416
• Fix internal or IntelliSense typos by @boflynn in Fix internal or IntelliSense typos #406
• Bump actions/setup-dotnet from 1 to 2 by @dependabot in Bump actions/setup-dotnet from 1 to 2 #431
• Bump actions/checkout from 2 to 3 by @dependabot in Bump actions/checkout from 2 to 3 #427
• Bump actions/cache from 2 to 3 by @dependabot in Bump actions/cache from 2 to 3 #429
• Bump actions/download-artifact from 2 to 3 by @dependabot in Bump actions/download-artifact from 2 to 3 #424

New Contributors

• @mikkelbu made their first contribution in fix: Correct comment about default TypeName #393
• @mariwing made their first contribution in Proper handling of TypeName = null from appsettings.json #420
• @andrey-kozlov-skuvault made their first contribution in Add ElasticsearchSinkOptions.BufferFileRollingInterval option #416
• @boflynn made their first contribution in Fix internal or IntelliSense typos #406
• @dependabot made their first contribution in Bump actions/setup-dotnet from 1 to 2 #431

Full Changelog: v8.4.1+4.build.444...v9.0.0-beta1

---

This discussion was created from the release v9.0.0-beta7.

[bandersen22000]

Will the final version support .NET framework ? The lib folder does not contain a net45 folder ?

[bandersen22000]

Okay just found the Breaking changes :(
Breaking changes
Version 9
Dropped support for 456 and sticking now with NETSTANDARD

[mivano]

Dropping support is my way to handle the load on this sink. I have not enough time to get support for this code path as well (let alone the build which was broken for months). Happy to accept a PR with support for more standards as long as it rolls out.

[bandersen22000]

@mivano Ok. And if I made a pull request for the 8.4.1 version with the changes the changes from Proper handling of TypeName = null from appsettings.json would that be ok for a version 8.4.2 ?

[mivano]

The v9 contains some other merged changes as well. So rather reengineer the needed support into the v9 than having multiple versions to support. I bumped it to v9 as it is a breaking change, the other changes are pretty minor.
It does need to work with the GitHub actions though so we can roll out packages.
If you know how and willing to do so, that would be really appreciated.

[RickSandstrom]

When is v9 going to be released as a non-beta? Any information about that?

[DmitriyBobrovskiy]

hey, can you explain me please why with same configuration, version 8.4.1 doesn't send logs to cloud elastic, but version 9.0.0-beta7 does?
I don't see any description in changelog about this?
thank you

[RickSandstrom]

We are also having trouble with 8.4.1 not logging to elastic 8.2, but the v9 beta works.

[zachawilson]

Installing v9.0.0-beta7 gives me the following runtime error:

Could not load file or assembly 'Serilog.Sinks.Elasticsearch' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key.

Is the beta package hosted on nuget.org signed? Are there other alternatives to getting the beta installed in my project?

Thank you.

[DmitriyBobrovskiy]

It's interesting that I've got the same error but with a bit different package (I was using Rider):

Could not load file or assembly 'Serilog.Formatting.Elasticsearch' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)

I agree that the problem is probably somehow related to .Net Framework and cannot give you any more details. I think we need info from @mivano.
One thing that I think you can do here is to change security level some way so not strongly signed signatures will be valid. I don't know how to do this though :)

[zachawilson]

Thank you for taking a look and confirming. I do get either of those package errors depending on the NuGet configuration.

For now I plan to proceed with 8.4.1 and move my configuration to be setup in code. The primary reason for wanting to pull in the beta is to be able to take advantage of #420 (and any other welcome fixes)

Any input is still appreciated and I'll give suggestions a try and respond.

[mivano]

Sorry, it took a while, but we found the culprit. The beta11 packages should be better now, maybe you can validate? Thanks for reporting.

[zachawilson]

@mivano Yes I can confirm that this is now acting as expected and the fixes I was looking to take advantage of are working. Thank you 🙏 .

[mivano]

Perfect, the 9.0.0-rc1 is the latest and I hope we can promote it to a stable release soon. Thanks for the feedback.